This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Split out edu/query registration to a separate class #2976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 13, 2018
richvdh
approved these changes
Mar 13, 2018
|
|
||
| Args: | ||
| edu_type (str): The type of the incoming EDU to register handler for | ||
| handler (Callable[str, dict]): A callable invoked on incoming EDU |
There was a problem hiding this comment.
I think Callable[str, dict] means "a thing that takes a str and returns a dict". You probably want Callable[[str, dict], Deferred[None]] or something?
There was a problem hiding this comment.
Oops, I misread the thingy. Ta.
| Args: | ||
| query_type (str): Category name of the query, which should match | ||
| the string used by make_query. | ||
| handler (Callable[dict] -> Deferred[dict]): Invoked to handle |
erikjohnston
force-pushed
the
erikj/replication_registry
branch
from
93862f5 to
f43b6d6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step towards properly splitting up the replication layer into client and server parts. The change is necessary to break the dependency cycle between the federation server and handlers.