This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add a metric which increments when a request is received #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rephrase the OPTIONS and unrecognised request handling so that they look similar to the common flow.
It's useful to know when there are peaks in incoming requests - which isn't quite the same as there being peaks in outgoing responses, due to the time taken to handle requests.
richvdh
commented
Mar 9, 2018
synapse/http/server.py
Outdated
| @@ -342,7 +350,7 @@ def _send_response(self, request, code, response_json_object, | |||
|
|
|||
|
|
|||
| def _options_handler(request): | |||
| return {} | |||
| return 200, {} | |||
There was a problem hiding this comment.
this should have been in dbe80a2, but I'm a crank
ara4n
reviewed
Mar 9, 2018
synapse/http/server.py
Outdated
| @@ -342,7 +350,7 @@ def _send_response(self, request, code, response_json_object, | |||
|
|
|||
|
|
|||
| def _options_handler(request): | |||
| return {} | |||
| return 200, {} | |||
There was a problem hiding this comment.
I was just finding it very confusing to try to guess whether the {} is a response body, or parsed URL segments, or what - especially _get_handler_for_request seems to append its own {} tuple alongside the returned handler... just a snidget of pydoc feels like it would be useful for confused bears
There was a problem hiding this comment.
(especially as it looks like you were confused too, based on missing the 200)
|
lgtm other than the one commentary request |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful to know when there are peaks in incoming requests - which isn't quite the same as there being peaks in outgoing responses, due to the time taken to handle requests.