This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Split out stream store #2924
Merged
Split out stream store #2924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/split_stream_store
branch
from
95fc18a to
a1702ed
Compare
erikjohnston
force-pushed
the
erikj/split_stream_store
branch
from
a1702ed to
f793bc3
Compare
richvdh
reviewed
Mar 1, 2018
| limit = max(limit, MAX_STREAM_SIZE) | ||
| else: | ||
| limit = MAX_STREAM_SIZE | ||
| class StreamWorkerStore(EventsWorkerStore, SQLBaseStore): |
There was a problem hiding this comment.
for the other abstract worker stores, you've documented the methods that need to be implemented. Could do it here too?
synapse/storage/stream.py
Outdated
| @@ -552,11 +421,13 @@ def get_room_events_max_id(self, room_id=None): | |||
| ) | |||
| defer.returnValue("t%d-%d" % (topo, token)) | |||
|
|
|||
| @abc.abstractmethod | |||
| def get_room_max_stream_ordering(self): | |||
There was a problem hiding this comment.
it might be more obvious if these were near the top of the class (with some comments about what they do...)
synapse/storage/__init__.py
Outdated
| @@ -148,14 +148,6 @@ def __init__(self, db_conn, hs): | |||
| stream_column="stream_ordering", | |||
| max_value=events_max, | |||
| ) | |||
| self._events_stream_cache = StreamChangeCache( | |||
There was a problem hiding this comment.
is the call to _get_cache_dict redundant now?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.