This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Move storage functions for push calculations #2913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow push actions for an event to be calculated on workers.
erikjohnston
changed the title
richvdh
reviewed
Feb 27, 2018
| "add_push_actions_to_staging", _add_push_actions_to_staging_txn | ||
| ) | ||
|
|
||
| def remove_push_actions_from_staging(self, event_id): |
There was a problem hiding this comment.
Are you going to be using this on the workers? I assumed it would just be for the master.
There was a problem hiding this comment.
Yeah, we use it if we throw an exception between persisting the push rules and persisting the event.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow push actions for an event to be calculated on workers.