This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Update pynacl dependency to 1.2.1 or higher #2888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
well, it happened in 0935802. I'm prepared to believe that whatever the problem was has been fixed in the last two years. |
|
@matrixbot test this please |
|
please could you rebase this on develop, and sign off, as per https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.rst |
Signed-off-by: Pascal Bach <[email protected]>
|
@richvdh Rebased and sign-off added. |
|
@matrixbot test this please |
|
lgtm, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if there was a reason why pynacl was fixed to 0.3.0. But i tried synapse with this patch on my homeserver and didn't experience any issues so far.