This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Remove some of the unused definitions from synapse #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 24 commits
September 22, 2015 18:13
…ng functions that aren't called at all
|
LGTM |
NegativeMjark
added a commit
that referenced
this pull request
Sep 28, 2015
Remove some of the unused definitions from synapse
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a script for finding unused definitions by walking the AST looking for names that only appear in definitions.
Remove some of the stuff that the script picked up on as being unused.
To find the unused definitions run the script with
The output needs to be taken with a pinch of salt since it will generate false positives for functions used by twisted or functions invoked by looking up the function using a string, e.g. render_GET.