This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
purge_history cleanups #2867
Merged
purge_history cleanups #2867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
richvdh
commented
Feb 14, 2018
richvdh
commented
- fix index use
- use a temporary table, which should speed things up by reducing the amount of data being shuffled across the connection
... which should speed things up by reducing the amount of data being shuffled across the connection
event_push_actions doesn't have an index on event_id, so we need to specify room_id.
synapse/storage/events.py
Outdated
| # create an index on should_delete because later we'll be looking for | ||
| # the should_delete / shouldn't_delete subsets | ||
| txn.execute("CREATE INDEX ON events_to_purge(should_delete)") | ||
|
|
There was a problem hiding this comment.
The docs suggest analyzing temp tables if you're going to do complex queries on it. Not sure if that applies in this case.
There was a problem hiding this comment.
yeah. I'd prefer to avoid that if possible, because it will need special-casing to just be postgres (because sqlite will commit the txn on analyze). Let's see how it works in practice.
erikjohnston
approved these changes
Feb 14, 2018
apparently creating a temporary table commits the transaction. because that's a useful thing.
apparently sqlite insists on indexes being named
| "CREATE TEMPORARY TABLE events_to_purge (" | ||
| " event_id TEXT NOT NULL," | ||
| " should_delete BOOLEAN NOT NULL" | ||
| ")" |
There was a problem hiding this comment.
You can just use """ triple quotes rather than quoting each line individually fwiw
erikjohnston
approved these changes
Feb 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.