This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Use a connection pool for the SimpleHttpClient #2817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular I hope this will help the pusher, which makes many requests to sygnal, and is currently negotiating SSL for each one.
|
retest this please |
erikjohnston
approved these changes
Jan 31, 2018
| # the pusher makes lots of concurrent SSL connections to sygnal, and | ||
| # tends to do so in batches, so we need to allow the pool to keep lots | ||
| # of idle connections around. | ||
| pool.maxPersistentPerHost = max((100 * CACHE_SIZE_FACTOR, 5)) |
There was a problem hiding this comment.
Although a 100 connections per host seems a bit overkill for a pool to have tbh. I'm not sure whether its worth making this configurable via CACHE_SIZE_FACTOR to be honest.
There was a problem hiding this comment.
I guess the point is that the pusher is a bit silly and needs that many connections, and so we may as well keep them around?
There was a problem hiding this comment.
the point is as described in the comments: yes it needs that many connections, and if we don't keep them around we end up killing ourselves with ssl nego.
using CACHE_SIZE_FACTOR was a crude hack to make it pool 1000 connections on matrix.org, and fewer on smaller homeservers.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular I hope this will help the pusher, which makes many requests to
sygnal, and is currently negotiating SSL for each one.