This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Ensure media is in local cache before thumbnailing #2791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/media_storage_refactor
branch
3 times, most recently
from
eab404a to
e8932f6
Compare
erikjohnston
force-pushed
the
erikj/media_storage_refactor
branch
from
e8932f6 to
5272ff1
Compare
erikjohnston
force-pushed
the
erikj/media_storage_refactor
branch
from
5272ff1 to
ce4f661
Compare
richvdh
reviewed
Jan 24, 2018
|
|
||
| for provider in self.storage_providers: | ||
| res = yield provider.fetch(path, file_info) | ||
| if res: |
There was a problem hiding this comment.
i'd be inclined to make this if not res:; continue, to reduce indentation, but no matter
This was referenced Apr 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If dynamic thumbnailing is disabled we know that we've just stored the file on disk when we go to generate thumbnails. However, if it is enabled then media may have been deleted from the local cache, in which case we need to download it again from a storage provider to the local cache.