This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Factor out a validate_user_via_ui_auth method #2728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
approved these changes
Dec 4, 2017
There was a problem hiding this comment.
Looks OK to me. Might be worth double checking with @dbkr in terms of the comment on password rest?
|
ja. @dbkr does e66e959?w=1#diff-f9718006007f57ac29470ca1f90b5fd9L109 look saneish to you? |
|
yep, lgtm |
Collect together all the places that validate a logged-in user via UI auth.
richvdh
force-pushed
the
rav/validate_user_via_ui_auth
branch
from
e66e959 to
d7ea8c4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect together all the places that validate a logged-in user via UI auth.
(includes #2727)