This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix bug in state group storage #2649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is internal to statestore, so let's keep it there.
This is duplicated, so let's factor it out before fixing it
Fixes a bug where the persisted state groups were different to those actually being used after auth resolution.
richvdh
force-pushed
the
rav/fix_delta_on_state_res
branch
from
97b8ef7 to
780dbb3
Compare
erikjohnston
approved these changes
Nov 7, 2017
synapse/handlers/federation.py
Outdated
| this will not be included in the current_state in the context. | ||
| """ | ||
| state_updates = { | ||
| k: a.event_id for k, a in auth_events.items() |
synapse/handlers/federation.py
Outdated
| context.delta_ids.update(state_updates) | ||
| context.prev_state_ids = dict(context.prev_state_ids) | ||
| context.prev_state_ids.update({ | ||
| k: a.event_id for k, a in auth_events.items() |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where the deltas stored for a state group were incorrect.
(See the individual commits: a couple of refactors before the actual change)