update prometheus-config to new format #2648
Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
contrib/prometheus/README
Outdated
| @@ -5,15 +5,20 @@ To use it, first install prometheus by following the instructions at | |||
|
|
|||
| http://prometheus.io/ | |||
|
|
|||
| Then add a new job to the main prometheus.conf file: | |||
| Then add a new job to the main prometheus.yml file: | |||
There was a problem hiding this comment.
prometheus.yml is working in my running setup
There was a problem hiding this comment.
prometheus.yaml is working in my running setup
This restores the config that is usable for prometheus pre v2.0.0 The new config only works for Prometheus v2+
|
how about separate "contrib/prometheus-v1" and "contrib/prometheus-v2" directories? I think that woudl be clearer |
|
The differences are only in different files for "synapse.rules" and some adjustment in the README. I can create two directories with two files each (README+synapse.rules) but I do not see the benefit... But if you prefer it I will do it |
|
hrm, if it wasn't for the console, then there would hardly be anything shared between v1 and v2 but fair enough |
|
Just for refence: I had to checkout the templates of the repos to use synapse.html that is in this repo. But synapse.html was usable without modification since I did that. |
|
the templates of the repos? |
Prometheus changed its format from simple config file to YAML for version 2.0.0 (changelog)
But the configs provided by this repo does not reflect that change.
Signed-Off-By: Matthias Kesler [email protected]