This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix various embarrassing typos around user_directory and add some doc. #2643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
richvdh
reviewed
Nov 6, 2017
|
|
||
| DROP INDEX users_in_pubic_room_room_idx; | ||
| DROP INDEX users_in_pubic_room_user_idx; | ||
| CREATE INDEX users_in_public_rooms_room_idx ON users_in_public_rooms(room_id); |
There was a problem hiding this comment.
are we doing this because sqlite doesn't support renaming index? A comment to say so would have been helpful.
erikjohnston
approved these changes
Nov 7, 2017
|
(FTR, recreating these indices on matrix.org only took a few seconds, so it should be fine) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.