This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Let password auth providers handle arbitrary login types #2620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbkr
reviewed
Nov 1, 2017
docs/password_auth_providers.rst
Outdated
| the login type, and a dictionary of login secrets passed by the client. | ||
|
|
||
| The method should return a Twisted ``Deferred`` object, which resolves to | ||
| the canonical `@localpart:domain`` user id if authentication is successful, |
Provide a hook where password auth providers can say they know about other login types, and get passed the relevant parameters
richvdh
force-pushed
the
rav/auth_non_password
branch
from
b2f9b2d to
3cd6b22
Compare
Yes, yes it would. When I first started this code that didn't work because of reasons to do with canonicalisation of user_ids, but it's now evolved to the point when that would be fine. Ho hum, another time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a hook where password auth providers can say they know about other
login types, and get passed the relevant parameters