Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

DB schema interface for password auth providers #2610

Merged
merged 2 commits into from
Oct 31, 2017

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Oct 31, 2017

Provide an interface by which password auth providers can register db schema
files to be run at startup

Provide an interface by which password auth providers can register db schema
files to be run at startup
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm I think


*class* ``SomeProvider.get_db_schema_files()``

This method, if implemented, should return an Iterable of ``(name,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth clarifying that this must be a file name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't really need to be a filename - any unique identifier will do

@dbkr dbkr assigned richvdh and unassigned dbkr Oct 31, 2017
@richvdh richvdh merged commit a72e4e3 into develop Oct 31, 2017
@richvdh richvdh deleted the rav/schema_for_pw_providers branch October 31, 2017 17:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants