Fix missprint (or CopyPaste) that brake push redact_content setting. #2422
Conversation
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
slipeer
changed the title
|
We now support this properly, ie. the clients can say whether they want event content to be sent in the push. Given this, and the fact that this has never worked, perhaps it would be better to just remove this? |
As the overhead of this implementation should not really impact the overall operation I would just fix the config. |
|
I'm all with you (@krombel). I don't want to rely on the clients in terms of privacy protection. Sending the event content in the push and exposing it to Google or Apple and even to the push gateway hosted by matrix.org shouldn't be an option at all! This is an easy fix! |
|
@dbkr Can you please merge this pull request? |
The redact_content option never worked because it read the wrong config section. The PR introducing it (#2301) had feedback suggesting the name be changed to not re-use the term 'redact' but this wasn't incorporated. This reanmes the option to give it a less confusing name, and also means that people who've set the redact_content option won't suddenly see a behaviour change when upgrading synapse, but instead can set include_content if they want to. This PR also updates the wording of the config comment to clarify that this has no effect on event_id_only push. Includes #2422
|
I've merged this into #2650 - hopefully this is good for everyone? |
|
it's good for me. |
Fix missprint (or CopyPaste) that brake push: redact_content setting.
There was mistake in config section name.