This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add ability to publicise group membership #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matrixbot retest this please |
1 similar comment
|
@matrixbot retest this please |
| @@ -150,6 +150,7 @@ CREATE TABLE local_group_membership ( | |||
| user_id TEXT NOT NULL, | |||
| is_admin BOOLEAN NOT NULL, | |||
| membership TEXT NOT NULL, | |||
| is_publicised TEXT NOT NULL, -- if the user is publicising their membership | |||
There was a problem hiding this comment.
Why is this a TEXT column?
|
Other than the schema oddities it looks good to me? |
|
@matrixbot retest this please |
3 similar comments
|
@matrixbot retest this please |
|
@matrixbot retest this please |
|
@matrixbot retest this please |
erikjohnston
force-pushed
the
erikj/groups_publicise
branch
from
ece80d6 to
8b50fe5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.