This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add group summary APIs #2363
Merged
Add group summary APIs #2363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/group_server_summary
branch
from
98f85b7 to
03ec252
Compare
erikjohnston
force-pushed
the
erikj/group_server_summary
branch
from
03ec252 to
8575e31
Compare
erikjohnston
force-pushed
the
erikj/group_server_summary
branch
from
10143df to
3b0470d
Compare
synapse/storage/group_server.py
Outdated
| txn.execute(""" | ||
| INSERT INTO group_summary_roles | ||
| (group_id, role_id, role_order) | ||
| SELECT ?, ?, COALESCE(MAX(role_order), 1) |
There was a problem hiding this comment.
Will this be larger than all the others, or the same as the largest?
synapse/storage/group_server.py
Outdated
| from ._base import SQLBaseStore | ||
|
|
||
| import ujson as json | ||
|
|
||
|
|
||
| # The category ID for the "default" category. We don't store as null in the | ||
| # database to avoid the fun of null != null | ||
| _DEFAULT_CATEGORY_ID = "default" |
There was a problem hiding this comment.
Maybe use the empty string as the default ID here?
| ) | ||
|
|
||
| @defer.inlineCallbacks | ||
| def on_POST(self, origin, content, query, group_id, category_id, room_id): |
There was a problem hiding this comment.
Maybe check that the category is not the default ID.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.