Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix removing of pushers when using workers #2267

Merged
merged 1 commit into from
Jun 9, 2017

Conversation

erikjohnston
Copy link
Member

Fixes:

2017-06-07 13:42:02,380 - twisted - 131 - CRITICAL -  - Unhandled error in Deferred:
2017-06-07 13:42:02,380 - twisted - 131 - CRITICAL -  - 
Traceback (most recent call last):
  File "/home/matrix/.synapse/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 1299, in _inlineCallbacks
    result = result.throwExceptionIntoGenerator(g)
  File "/home/matrix/.synapse/local/lib/python2.7/site-packages/twisted/python/failure.py", line 393, in throwExceptionIntoGenerator
    return g.throw(self.type, self.value, self.tb)
  File "synapse/util/metrics.py", line 58, in measured_func
  File "/home/matrix/.synapse/local/lib/python2.7/site-packages/twisted/internet/defer.py", line 1301, in _inlineCallbacks
    result = g.send(result)
  File "synapse/replication/tcp/resource.py", line 231, in on_remove_pusher
AttributeError: 'ReplicationStreamer' object has no attribute 'notifier'

Copy link
Contributor

@NegativeMjark NegativeMjark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erikjohnston erikjohnston merged commit bfd6801 into develop Jun 9, 2017
@erikjohnston erikjohnston deleted the erikj/missing_notifier branch October 26, 2017 11:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants