This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Speed up calculating push rules #2238
Merged
+23
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if key[0] != EventTypes.Member: | ||
| continue | ||
|
|
||
| user_id = key[1] |
There was a problem hiding this comment.
If we are optimising it might be worth noting that a, b = key seems to be faster than a = key[0], b = key[1]
| @@ -200,6 +200,10 @@ def __init__(self, hs, room_id, rules_for_room_cache): | |||
| # not update the cache with it. | |||
| self.sequence = 0 | |||
|
|
|||
| # A cache of user_ids that we *know* aren't interesting, e.g. user_ids | |||
| # owned by AS's, or remote users, etc. | |||
| self.uninteresting_user_set = set() | |||
There was a problem hiding this comment.
Could we have a comment explaining why this cache doesn't need invalidation.
There was a problem hiding this comment.
Also might be worth explaining that "uninteresting" means "will never have push rules on this server"
|
Other than commenting on the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.