Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Use twisted logger for top level exception handlers #2074

Closed
wants to merge 1 commit into from

Conversation

erikjohnston
Copy link
Member

As the twisted logger is more likely to report the actual stack trace

As the twisted logger is more likely to report the actual stack trace
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sensible.

Is this a thing we should be doing throughout? Why not do the entire file?

Will lines logged this way get recorded with the correct logcontext?

@erikjohnston
Copy link
Member Author

We should think about this a bit more

@richvdh
Copy link
Member

richvdh commented May 3, 2018

FTR #2705 superceded most of this and I think is a better solution. As I wrote there:

I'm not super-keen on using the twisted logger per se, because it means that we lose log categories etc. Nevertheless, it turns out that we can do what the twisted logger does to recover the original Failure, and get the best of both worlds.

@hawkowl hawkowl deleted the erikj/use_twisted_log branch September 20, 2018 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants