This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Always return a thumbnail of the requested size. #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, we returned a thumbnail that was at least as big (if possible) as the requested size. Now, if we don't have a thumbnail of the given size we generate (and persist) one of that size.
|
Actually, we should probably make this configurable. |
|
Could you de-duplicate the "thumbnail" function by passing the thumbnail path as an argument? |
| request, media_id, width, height, method, m_type | ||
| ) | ||
| else: | ||
| yield self._respond_remote_thumbnail( | ||
| yield self._select_or_generate_remote_thumbnail( | ||
| request, server_name, media_id, |
There was a problem hiding this comment.
Presumably this will switch between _respond_remote_thumbnail and _select_or_generate_remote_thumbnail when the config option is added.
erikjohnston
force-pushed
the
erikj/generate_presice_thumbnails
branch
from
6bbe02f to
4590851
Compare
added 5 commits
August 12, 2015 10:54
|
LGTM |
NegativeMjark
added a commit
that referenced
this pull request
Aug 20, 2015
…ails Always return a thumbnail of the requested size.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we returned a thumbnail that was at least as big (if possible)
as the requested size. Now, if we don't have a thumbnail of the given
size we generate (and persist) one of that size.