This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Don't user upsert to persist new one time keys #2053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead we no-op duplicate one time key uploads, an error if the key_id already exists but encodes a different key.
|
Oh, I suppose I should raise a more helpful exception |
|
(I'm now raising a slightly more helpful exception) |
richvdh
suggested changes
Mar 24, 2017
| # First we check if we have already persisted any of the keys. | ||
| rows = yield self._simple_select_many_batch( | ||
| table="e2e_one_time_keys_json", | ||
| column="key_id", |
There was a problem hiding this comment.
technically the algorithm is part of the key - so it's valid to have an "ed25519:aaaaa" as well as a "rot13:aaaaa". I rather hope the index reflects that, but haven't checked...
There was a problem hiding this comment.
Oh bleurgh, thanks, have changed.
| # We are protected from race between lookup and insertion due to | ||
| # a unique constraint. If there is a race of two calls to | ||
| # `add_e2e_one_time_keys` then they'll conflict and we will only | ||
| # insert one set. |
There was a problem hiding this comment.
... and throw a 500 or something, presumably? I suppose that's fine because the client should retry on the 500 and hit the api again, at which point the lookup should conclude that it's all fine.
|
modulo test failures. what's all that about? |
|
Whoops, look like I was a crank. Hopefully fixed now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead we no-op duplicate one time key uploads, an error if the key_id
already exists but encodes a different key.