This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Store the default push actions in a more efficient manner #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| def _serialize_action(actions, is_highlight): | ||
| """Custom serializer for actions. This allows us to "compress" common actions |
There was a problem hiding this comment.
Maybe explain what the compression scheme is?
erikjohnston
force-pushed
the
erikj/push_action_compress
branch
from
e17f031 to
0b8e0dd
Compare
erikjohnston
force-pushed
the
erikj/push_action_compress
branch
from
0b8e0dd to
9501033
Compare
erikjohnston
force-pushed
the
erikj/push_action_compress
branch
from
9501033 to
502ae6c
Compare
| """Custom serializer for actions. This allows us to "compress" common actions. | ||
|
|
||
| We use the fact that most users have the same actions for notifs (and for | ||
| highlights). We replaces these default actions with the emtpy string. |
There was a problem hiding this comment.
"replaces", "emtpy"
Maybe something more along the lines of "We store these default actions as the empty string rather than the full JSON. Since the empty string isn't valid JSON there is no risk of this clashing with any real JSON actions."
erikjohnston
added a commit
that referenced
this pull request
Mar 13, 2017
Changes in synapse v0.19.3-rc1 (2017-03-08) =========================================== Features: * Add some administration functionalities. Thanks to morteza-araby! (PR #1784) Changes: * Reduce database table sizes (PR #1873, #1916, #1923, #1963) * Update contrib/ to not use syutil. Thanks to andrewshadura! (PR #1907) * Don't fetch current state when sending an event in common case (PR #1955) Bug fixes: * Fix synapse_port_db failure. Thanks to Pneumaticat! (PR #1904) * Fix caching to not cache error responses (PR #1913) * Fix APIs to make kick & ban reasons work (PR #1917) * Fix bugs in the /keys/changes api (PR #1921) * Fix bug where users couldn't forget rooms they were banned from (PR #1922) * Fix issue with long language values in pushers API (PR #1925) * Fix a race in transaction queue (PR #1930) * Fix dynamic thumbnailing to preserve aspect ratio. Thanks to jkolo! (PR #1945) * Fix device list update to not constantly resync (PR #1964) * Fix potential for huge memory usage when getting device that have changed (PR #1969)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.