This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add an index to make membership queries faster #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.CURRENT_STATE_INDEX_UPDATE_NAME, | ||
| index_name="current_state_events_member_index", | ||
| table="current_state_events", | ||
| columns=["state_key"], |
There was a problem hiding this comment.
should this be ["room_id", "state_key"]?
There was a problem hiding this comment.
Oh I see, this for rooms_for_user so you want to look up by user_id = state_key.
There was a problem hiding this comment.
No because we're looking up the room. The query we're optimising is essentially:
SELECT * FROM current_state_events WHERE type = 'm.room.member' AND state_key = ?The type is in the where clause.
There was a problem hiding this comment.
And the users_in_room is already handled by the (room_id, type, state_key) index.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.