This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Better handle 404 response for federation /send/ #1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synapse/util/retryutils.py
Outdated
|
|
||
| def __enter__(self): | ||
| pass | ||
|
|
||
| def __exit__(self, exc_type, exc_val, exc_tb): | ||
| valid_err_code = False | ||
| if exc_type is not None and issubclass(exc_type, CodeMessageException): | ||
| valid_err_code = exc_val.code != 429 and 0 <= exc_val.code < 500 | ||
| if exc_val.code < 400: |
There was a problem hiding this comment.
Maybe chuck in a short comment explaining what's going on here? Just to explain what a valid_err_code is and why 404, 429 and >500 are special?
synapse/util/retryutils.py
Outdated
| # APIs may expect to never received e.g. a 404. It's important to | ||
| # handle 404 as some remote servers will return a 404 when the HS | ||
| # has been decommissioned. | ||
| if exc_val.code < 400: |
There was a problem hiding this comment.
Isn't the exc_val.code < 400 redundant because of the exc_val.code < 500 ?
There was a problem hiding this comment.
Yeah, though personally I quite like the fact that each case of code is handled in order. I can change it if you think it makes it clearer?
There was a problem hiding this comment.
I find it misleading because it makes it seem as though 4xx are handled differently to 2xx/3xx.
|
LGTM apart from the possibly redundant check? |
|
@matrixbot retest this please |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.