This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix clearing out old device list outbound pokes #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -557,6 +557,9 @@ def _prune_txn(txn): | |||
| txn.execute(select_sql) | |||
| rows = txn.fetchall() | |||
|
|
|||
| if not rows: | |||
| return | |||
There was a problem hiding this comment.
Should we chuck a min(ts) into the SELECT so that we can filter out destinations that don't have anything to delete in them? I'm slightly worried at the number of deletes that we are spamming here.
There was a problem hiding this comment.
I wouldn't expect min(ts) < ? to filter out many rows though, as most users won't update particularly frequently.
There was a problem hiding this comment.
If you throw in a count then you could probably discard all the destination, user_id pairs that only have a single row in them.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.