Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Drop unused tables & unneeded access token ID for events. #16522

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

clokep
Copy link
Member

@clokep clokep commented Oct 18, 2023

This relands #16268 which was backed out in #16465.

This depends on #16521, which will hopefully land in Synapse 1.96.0. Meaning this PR can land in 1.98.0.

Fixes #16042 and fixes #15786.

@clokep clokep force-pushed the clokep/txn-clean-up branch from dfe6bff to 7c155a3 Compare November 29, 2023 15:17
@clokep clokep marked this pull request as ready for review November 29, 2023 15:17
@clokep clokep requested a review from a team as a code owner November 29, 2023 15:17
@clokep
Copy link
Member Author

clokep commented Nov 29, 2023

Let's try this again...

@clokep
Copy link
Member Author

clokep commented Nov 29, 2023

I'm fairly certain I caught all usages of these tables this time. 😄

Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@erikjohnston erikjohnston merged commit 579c6be into develop Dec 1, 2023
41 checks passed
@erikjohnston erikjohnston deleted the clokep/txn-clean-up branch December 1, 2023 10:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean-up event_txn_id table Gracefully drop MSC2716 related tables (incrementally import history)
2 participants