Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Log the args that we have on UI auth completion #1649

Merged
merged 2 commits into from
Dec 5, 2016
Merged

Log the args that we have on UI auth completion #1649

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f681aab
Log the args that we have on UI auth completion
dbkr Nov 24, 2016
c9d4e7b
Clarify that creds doesn not contain passwords.
dbkr Nov 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion synapse/handlers/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,15 @@ def check_auth(self, flows, clientdict, clientip):

for f in flows:
if len(set(f) - set(creds.keys())) == 0:
logger.info("Auth completed with creds: %r", creds)
# it's very useful to know what args are stored, but this can
# include the password in the case of registering, so only log
# the keys (confusingly, clientdict may contain a password
# param, creds is just what the user authed as for UI auth
# and is not sensitive).
logger.info(
"Auth completed with creds: %r. Client dict has keys: %r",
creds, clientdict.keys()
)
defer.returnValue((True, creds, clientdict, session['id']))

ret = self._auth_dict_for_flows(flows, session)
Expand Down