Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix the type annotation on run_db_interaction in the Module API. #16089

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Fix the type annotation on run_db_interaction in the Module API. #16089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c2f313
Fix the method signature of `run_db_interaction` on the module API
reivilibre Aug 9, 2023
07f7dc8
Newsfile
reivilibre Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/16089.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix the type annotation on `run_db_interaction` in the Module API.
4 changes: 2 additions & 2 deletions synapse/module_api/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@

import attr
import jinja2
from typing_extensions import ParamSpec
from typing_extensions import Concatenate, ParamSpec

from twisted.internet import defer
from twisted.internet.interfaces import IDelayedCall
Expand Down Expand Up @@ -885,7 +885,7 @@ def invalidate_access_token(
def run_db_interaction(
self,
desc: str,
func: Callable[P, T],
func: Callable[Concatenate[LoggingTransaction, P], T],
*args: P.args,
**kwargs: P.kwargs,
) -> "defer.Deferred[T]":
Expand Down