This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Remove whole table locks on push rule add/delete #16051
Merged
erikjohnston
merged 11 commits into
matrix-org:develop
from
beeper:remove-push-rule-table-locks
Nov 13, 2023
+28
−16
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
32e0bd3
Remove whole table locks on push rule add/delete
Fizzadar 0938542
Add changelog
Fizzadar ab88d3f
Use `FOR SHARE` to lock selected push rule rows on relative update
Fizzadar d90cef1
Fix `FOR SHARE` handling of push rule transactions
Fizzadar 4dbee68
Use `FOR UPDATE` to ensure selects conflict
Fizzadar 2ec17da
Rewrite highest priority rule txn to use FOR UPDATE in one query
Fizzadar 3282065
Merge branch 'develop' into remove-push-rule-table-locks
Fizzadar 7d10544
Remove leftover quote
Fizzadar 576605e
Revert "Rewrite highest priority rule txn to use FOR UPDATE in one qu…
Fizzadar 376313e
Add missing `txn.execute` on `FOR UPDATE` statement
Fizzadar 7937ac0
Merge branch 'develop' into remove-push-rule-table-locks
Fizzadar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix
FOR SHARE
handling of push rule transactions
commit d90cef157062d1ca4baf6d8225c8f3362e765eb6
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth doing a
txn.execute
for this SQL? 😆There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But also, you probably want to do this as part of the
COUNT(*)
query below?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep good spot - 2ec17da
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still missing a
tx.execute
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gah, missed after rewriting it again in 2ec17da; fix: 376313e