Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Bump DB version to 79 since synapse v1.88 was already there #15998

Merged
merged 3 commits into from
Jul 26, 2023

Conversation

MatMaul
Copy link
Contributor

@MatMaul MatMaul commented Jul 25, 2023

We accidentally removed 79 deltas folder and version bump with a revert.

The 2 applied deltas of the reverted commit will stayed applied, meaning that we don't have the NOT NULL constraint on user_id column of tables profiles and user_filters.
I think this is fine, but tagging you @H-Shay to have an extra pair of eyes on that.

Pull Request Checklist

@erikjohnston
Copy link
Member

@MatMaul Can I check that the delta files you moved are safe to run twice?

@MatMaul
Copy link
Contributor Author

MatMaul commented Jul 25, 2023

@erikjohnston you mean you or me ? Feel free to check I am not rushing this change and will probably delay a bit the RC.

If you mean me welllll I had a quick look and I am not sure I am qualified to say 😅

@anoadragon453 anoadragon453 added the X-Release-Blocker Must be resolved before making a release label Jul 25, 2023
@MatMaul MatMaul marked this pull request as ready for review July 25, 2023 14:44
@MatMaul MatMaul requested a review from a team as a code owner July 25, 2023 14:44
@H-Shay
Copy link
Contributor

H-Shay commented Jul 26, 2023

that we don't have the NOT NULL constraint on user_id column of tables profiles and user_filters

I think this should be fine? We have stopped reading from these columns entirely and next release will stop writing to them in preparation to be dropped so I think it should be fine.

@MatMaul
Copy link
Contributor Author

MatMaul commented Jul 26, 2023

@H-Shay that's what I thought, thanks for having a look.

@erikjohnston after looking more carefully I found quite a bunch of trouble regarding re-run of those deltas, I think I catch them all, if you can have a quick look.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
X-Release-Blocker Must be resolved before making a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants