Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Better warning in logs when we fail to fetch an alias #15922

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Better warning in logs when we fail to fetch an alias #15922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
205bf88
Better warning in logs when we fail to fetch an alias
MadLittleMods Jul 11, 2023
293fbf8
Add changelog
MadLittleMods Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/15922.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add details to warning in log when we fail to fetch an alias.
4 changes: 3 additions & 1 deletion synapse/handlers/directory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,9 @@ async def get_association(self, room_alias: RoomAlias) -> JsonDict:
except RequestSendFailed:
raise SynapseError(502, "Failed to fetch alias")
except CodeMessageException as e:
logging.warning("Error retrieving alias")
logging.warning(
"Error retrieving alias %s -> %s %s", room_alias, e.code, e.msg
)
if e.code == 404:
fed_result = None
else:
Expand Down