Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Use CAS protocol version 3 to properly retrieve user attributes #15811

Closed
wants to merge 0 commits into from
Closed

Use CAS protocol version 3 to properly retrieve user attributes #15811

wants to merge 0 commits into from

Conversation

agrimpard
Copy link
Contributor

@agrimpard agrimpard commented Jun 21, 2023 •
edited
Loading

Synapse doesn't retrieve CAS attributes with protocol version 2, so we're switching to version 3.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

Signed-off-by: Aurélien Grimpard [email protected]

@agrimpard agrimpard requested a review from a team as a code owner June 21, 2023 08:53
clokep
clokep reviewed Jun 21, 2023
View reviewed changes
synapse/handlers/cas.py Outdated
@@ -120,7 +120,7 @@ async def _validate_ticket(
Returns:
The parsed CAS response.
"""
uri = self._cas_server_url + "/proxyValidate"
uri = self._cas_server_url + "/p3/proxyValidate"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this break non-v3 servers? Do we need to fallback to this URL or have configuration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've no way to test with v2.
I'm adding a configuration for v3, that will be better ...

@clokep clokep linked an issue Jun 21, 2023 that may be closed by this pull request
Synapse doesn't retrieve CAS attributes when using CAS Protocol 3.0 #15807
Closed
@clokep clokep changed the title Fix CAS not retrieving attributes Use CAS protocol version 3 to properly retrieve user attributes Jun 21, 2023
@clokep
Copy link
Member

clokep commented Jun 21, 2023

I assume this fixes #15807?

@agrimpard agrimpard closed this Jun 21, 2023
@agrimpard agrimpard mentioned this pull request Jun 21, 2023
Merged
4 tasks
@MadLittleMods MadLittleMods added the z-auth (Deprecated Label) label Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clokep clokep clokep left review comments

Assignees
No one assigned
Labels
z-auth (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Synapse doesn't retrieve CAS attributes when using CAS Protocol 3.0
3 participants
@agrimpard @clokep @MadLittleMods