Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove undocumented room_alias key from /createRoom response #14884

Closed
wants to merge 4 commits into from
Closed

Remove undocumented room_alias key from /createRoom response #14884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
39a5276
Solved Issue 10321
thezaidbintariq Jan 21, 2023
492b4cc
Update changelog.d/10321.removal
thezaidbintariq Jan 21, 2023
d0f8ff6
Changes the changelog file name
thezaidbintariq Jan 21, 2023
2e8a46e
Merge branch 'develop' into patch-3
thezaidbintariq Jan 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/14884.removal
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove undocumented `room_alias` key from `/createRoom` response. Contributed by @thezaidbintariq.
3 changes: 0 additions & 3 deletions synapse/handlers/room.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1033,9 +1033,6 @@ async def create_room(

result = {"room_id": room_id}

if room_alias:
result["room_alias"] = room_alias.to_string()

# Always wait for room creation to propagate before returning
await self._replication.wait_for_stream_position(
self.hs.config.worker.events_shard_config.get_instance(room_id),
Expand Down