Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix #12880 : notifications stop to work if last read event has been purged in a room #14441

Closed
wants to merge 2 commits into from
Closed

Fix #12880 : notifications stop to work if last read event has been purged in a room #14441

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78e174e
Fix 12880
laurent-treeb Nov 14, 2022
5c3a99d
Merge branch 'release-v1.61' into hotfix/12880
laurent-treeb Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion synapse/storage/databases/main/event_push_actions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,10 @@ def get_after_receipt(
# There are rooms with push actions in them but you don't have a read receipt in
# them e.g. rooms you've been invited to, so get push actions for rooms which do
# not have read receipts in them too.

# BUG https://github.com/matrix-org/synapse/issues/12880#
# OR rooms that have read receipt but the event pointed by the read receipt has been purged

def get_no_receipt(
txn: LoggingTransaction,
) -> List[Tuple[str, str, int, str, bool]]:
Expand All @@ -344,18 +348,27 @@ def get_no_receipt(
" FROM event_push_actions AS ep"
" INNER JOIN events AS e USING (room_id, event_id)"
" WHERE"
" ("
" ep.room_id NOT IN ("
" SELECT room_id FROM receipts_linearized"
" WHERE receipt_type = 'm.read' AND user_id = ?"
" GROUP BY room_id"
" )"
" OR ep.room_id IN ("
" SELECT room_id FROM receipts_linearized rli"
" LEFT JOIN events as rlievt USING (room_id, event_id)"
" WHERE rlievt.event_id is null"
" AND rli.receipt_type = 'm.read'"
" AND rli.user_id = ?"
" )"
" )"
" AND ep.user_id = ?"
" AND ep.stream_ordering > ?"
" AND ep.stream_ordering <= ?"
" AND ep.notif = 1"
" ORDER BY ep.stream_ordering ASC LIMIT ?"
)
args = [user_id, user_id, min_stream_ordering, max_stream_ordering, limit]
args = [user_id, user_id, user_id, min_stream_ordering, max_stream_ordering, limit]
txn.execute(sql, args)
return cast(List[Tuple[str, str, int, str, bool]], txn.fetchall())

Expand Down