Don't put the servername in the filename of the default logging conf

[behrmann]

Pull Request Checklist

As just touched on in #13669. This is probably still missing something and I haven't tested this, but I wanted to open it as a sort of todo.

/cc @richvdh

• Pull request is based on the develop branch
• Pull request includes a changelog file. The entry should:
  • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
  • Use markdown where necessary, mostly for code blocks.
  • End with either a period (.) or an exclamation mark (!).
  • Start with a capital letter.
  • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
• Pull request includes a sign off
• Code style is correct
  (run the linters)

[richvdh]

If you're renaming a conffile in debian packaging, you need to add stuff to the pre/postinst to help users.

See https://manpages.debian.org/unstable/dpkg/dpkg-maintscript-helper.1.en.html for more.

[richvdh]

Also, if it's a yaml file, I think it should be called *.yaml. Your concern that synapse might treat it as a regular config file if you put it in the config directory is noted... so don't do that?

[behrmann]

If you're renaming a conffile in debian packaging, you need to add stuff to the pre/postinst to help users.

Will look into implementing a helper for that.

Also, if it's a yaml file, I think it should be called *.yaml. Your concern that synapse might treat it as a regular config file if you put it in the config directory is noted... so don't do that?

I think that's a foot gun I'd rather not implement. I'm sure that's an edge case, but since --config-path= can take directories and the config directory defaults to the directory of the last found config file I could foresee situations where (missing) config files are generated in the same directory where --config-path= is pointed to.

[clokep]

@behrmann Do you have interest in finishing this up?

[behrmann]

Yes, sorry about the delay. Been swamped with other work. This is at the top of my synapse todo list for what it's worth. Will try to get back to it asap.