This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Don't pull out the full state when storing state #13274
Merged
+132
−71
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f98c691
Fix bug where the state deltas were incorrect
erikjohnston efd5c32
Fix bug where we didn't calculate the state correctly for new events
erikjohnston b92429f
Add test
erikjohnston eb6e0aa
Newsfile
erikjohnston 055c2a7
Don't pull out the full state group when storing state
erikjohnston d761cb8
Newsfile
erikjohnston f4866ce
Fix test
erikjohnston 3be91b5
Apply suggestions from code review
erikjohnston 12fd634
Hoist
erikjohnston 6a85078
Comments
erikjohnston ff5bad6
Update synapse/storage/databases/state/store.py
erikjohnston bc1adf3
Remove optional part
erikjohnston 061ce1d
Before comment
erikjohnston 876004f
Merge remote-tracking branch 'origin/develop' into erikj/less_state_p…
erikjohnston File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix test
commit f4866ce531e16e64dac9f1e1828c045254680910
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit surprised these transaction counts increase. AFAICT the only reason we would end up doing more transactions is if we start doing an
insert_delta_group_txn
but abort that because the delta chain is too long. Any ideas?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its where we add the
replaces_state
to the unsigned section:https://github.com/matrix-org/synapse/pull/13274/files#diff-d05c474c9fe45057f52616f38e54f6cdb3fa80a5a596ecb9c8fec3026ff8d68eR343-R346
So in the test we pull out some partial state for the group there, and then when we come to create the next event we pull out some other partial state for the group