This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Rip out auth-event reconciliation code #12943
Merged
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ac028f3
Rename some variables
richvdh e5403a5
Rip out auth-event reconciliation code
richvdh 5b5ce5e
Do an early return when the two sets of auth events are the same.
richvdh 7f6d721
Log the differences when the auth events are not the same.
richvdh 2b80c6e
Improve logging when auth fails
richvdh 77c6b2d
Update some comments
richvdh 58fb17d
Stop returning `EventContext` from `_check_event_auth`
richvdh 9f5baec
Reconcile state when processing incoming events during faster joins
richvdh 0a11a39
Revert "Fix backfilled events being rejected for no `state_groups` (#…
richvdh ea54ba7
changelog
richvdh ad0c9b0
Merge branch 'develop' into rav/rip_out_event_auth_reconciliation
richvdh 9806768
Merge branch 'develop' into rav/rip_out_event_auth_reconciliation
richvdh 0988441
add clarifying comment
richvdh e0eec69
Merge remote-tracking branch 'origin/develop' into rav/rip_out_event_…
richvdh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth mentioning that we will have fetched any missing auth events before we reach this point? It wasn't immediately obvious to me why we'd have the auth events but not the state.