This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add config option for adding additional TLS fingerprints #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Homeservers are permitted to cache the list of TLS fingerprints | ||
| # returned in the key responses. It may be necessary to publish the | ||
| # fingerprints of a new certificate and wait for the caches on other | ||
| # servers to expire before deploying it. |
There was a problem hiding this comment.
This worries me a bit if we're not explicit about the cache invaliadtion timings
| # fingerprints of a new certificate and wait for the caches on other | ||
| # servers to expire before deploying it. | ||
| tls_fingerprints: [] | ||
| #- {"sha256": "<base64_encoded_sha256_fingerprint>"} |
There was a problem hiding this comment.
This is a confusing way of giving an example, I was quite confused for a minute. Maybe:
tls_fingerprints: []
# tls_fingerprints: [{"sha256": "<base64_encoded_sha256_fingerprint>"}, ...]| @@ -49,7 +47,8 @@ class LocalKey(Resource): | |||
| "key": # base64 encoded NACL verification key. | |||
| } | |||
| } | |||
| "tls_certificate": # base64 ASN.1 DER encoded X.509 tls cert. | |||
| "tls_fingerprints": # Fingerprints of the TLS certs this server uses. | |||
| - {"sha256": "..."} | |||
There was a problem hiding this comment.
- This is JSON not yaml
- Are we actually changing the API here? Won't that affect when other servers look up keys?
There was a problem hiding this comment.
We aren't changing the API. The comment is just a tiny bit out of date.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.