This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add experimental support for MSC3202: allowing application services to masquerade as specific devices. #11538
Merged
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a39ccfc
Expand return type of get_appservice_user_id to allow returning a dev…
reivilibre be8814f
Expand get_user_by_req to support handling a device ID
reivilibre 7ea5022
Remove superfluous lines
reivilibre 9551a3e
Remove early return because we need more logic here
reivilibre 86ef692
Add get_device_opt which returns None instead of raising if it doesn'…
reivilibre d3b0be5
Allow masquerading as a device by specifying the device_id URI parameter
reivilibre 8a078ce
Newsfile
reivilibre cc2bbcd
Switch to the 400 M_EXCLUSIVE error code for non-existent device IDs
reivilibre 7e39806
Add a pair of tests for the ?device_id parameter for AS device masque…
reivilibre ae968ea
Add an experimental flag to control device masquerading
reivilibre 11e2192
Update tests to enable experimental features
reivilibre 63042ac
Use get_device (fixing in upstream develop)
reivilibre 2becd52
TEMPORARY Revert "Use get_device (fixing in upstream develop)"
reivilibre 405f3f9
Fix comment
reivilibre 075a2b7
Merge branch 'develop' into rei/as_device_masquerading_msc3202
reivilibre 15cb2f0
Use get_device
reivilibre 24e3fad
Merge branch 'develop' into rei/as_device_masquerading_msc3202
reivilibre f35234a
Fix up: mock get_device in lieu of get_device_opt (since changes from…
reivilibre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be nicer if we just switched
get_device
to return anOptional
, and then change up the callers to look forNone
instead of aStoreError
.That would also fix up callers that seem to currently 500 if a device isn't found(!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Span out to #11565 .