This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
make device IDs more useful for human disambiguation #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given we check for collisions and retry, that sounds perfectly acceptable. LGTM |
|
thanks. i'm assuming the test failures are due to jenkins having a meltdown and going to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently synapse generates unique IDs for devices which are horrible for human disambiguation of devices as they are long and contain a variety of homoglyphs and generally look ugly to the eye - e.g.
Hu3d_G:;jj3*D:rF.This makes them simpler - 10 upper case characters. It does reduce the available device IDs from (26+26+10+15)^16 (1E30) to 26^10 (1E14), but I think the tradeoff is probably acceptable in terms of making the IDs more usable as a means of distinguishing one Vector running on Chrome from another Vector running on Chrome.