This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Send device messages over federation #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 6, 2016 11:26
Adds tables for storing the messages that need to be sent to a remote device and for deduplicating messages received.
| Returns: | ||
| Deferred ([dict], int): List of messages for the device and where | ||
| in the stream the messages got to. | ||
| """ |
There was a problem hiding this comment.
This probably wants to be behind a stream change cache to avoid hitting the DB for every TXN we want to send.
There was a problem hiding this comment.
Yes. We send a lot of transactions, so this needs to be optimised.
added 5 commits
September 7, 2016 12:03
Move the check into _attempt_new_transaction. Only delete messages if there were messages to delete.
|
@erikjohnston This PR might have become non-awful enough to actually land PTAL. |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: