Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Clean up old sent transactions #1059

Merged
merged 1 commit into from
Aug 31, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions synapse/storage/schema/delta/34/sent_txn_purge.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# Copyright 2016 OpenMarket Ltd
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

from synapse.storage.engines import PostgresEngine

import logging

logger = logging.getLogger(__name__)


def run_create(cur, database_engine, *args, **kwargs):
if isinstance(database_engine, PostgresEngine):
cur.execute("TRUNCATE sent_transactions")
else:
cur.execute("DELETE FROM sent_transactions")

cur.execute("CREATE INDEX sent_transactions_ts ON sent_transactions(ts)")


def run_upgrade(cur, database_engine, *args, **kwargs):
pass
2 changes: 2 additions & 0 deletions synapse/storage/transactions.py
Original file line number Diff line number Diff line change
Expand Up @@ -387,8 +387,10 @@ def f(txn):
def _cleanup_transactions(self):
now = self._clock.time_msec()
month_ago = now - 30 * 24 * 60 * 60 * 1000
six_hours_ago = now - 6 * 60 * 60 * 1000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why six hours for this one, but one month for the other?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, mainly because otherwise the matrix.org table becomes huuuuuuuge.


def _cleanup_transactions_txn(txn):
txn.execute("DELETE FROM received_transactions WHERE ts < ?", (month_ago,))
txn.execute("DELETE FROM sent_transactions WHERE ts < ?", (six_hours_ago,))

return self.runInteraction("_persist_in_mem_txns", _cleanup_transactions_txn)