This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Allow application services to have an optional 'url' #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If 'url' is not specified, they will not be pushed for events or queries. This is useful for bots who simply wish to reserve large chunks of user/alias namespace, and don't care about being pushed for events.
|
I was going to say that the PR could be called 'Make the appservice "URL" optional in the appservice config'. But it's not really optional. Maybe call this 'Make "URL" optional in the appservice config in a really awkward way to prevent people omitting it by accident'? :) |
|
YAML can represent |
| if as_info["url"] == "": | ||
| logger.info( | ||
| "(%s) Explicitly empty 'url' provided. This application service " + | ||
| "will not receive events or queries.", |
There was a problem hiding this comment.
I'd probably start the line " will since it makes it easier to spot the spaces. Also I'd be tempted to omit the '+' operator.
|
Looks alright apart from the comments. |
Change how we validate the 'url' field as a result.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If 'url' is not specified, they will not be pushed for events or queries. This is useful for bots who simply wish to reserve large chunks of user/alias namespace, and don't care about being pushed for events.
This is done by explicitly setting the
urlfield in the registration file to the empty string. This is done to ensure that this is a conscious decision, and not just a forgotten field. We also log when we encounter ASes which will not be pushed.