Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix saml.DefaultSamlMappingProvider import #10477

Merged
merged 2 commits into from
Jul 27, 2021
Merged

Fix saml.DefaultSamlMappingProvider import #10477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a64f1c5
Fix saml.DefaultSamlMappingProvider import
jaywink Jul 26, 2021
befcb04
Update changelog.d/10477.bugfix
jaywink Jul 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/10477.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix bug introduced in Synapse 1.38 which caused an exception at startup when SAML authentication was enabled.
2 changes: 0 additions & 2 deletions synapse/handlers/_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@
import logging
from typing import TYPE_CHECKING, Optional

import synapse.state
import synapse.storage
Comment on lines -18 to -19
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if these were really unused... why didn't the linter pick them up? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think because they're just importing the module (as opposed to from foo import bar, but I had the same thought...

import synapse.types
from synapse.api.constants import EventTypes, Membership
from synapse.api.ratelimiting import Ratelimiter
Expand Down