Fix dropping locks on shut down

changelog.d/10433.bugfix

@@ -0,0 +1 @@
+Fix error while dropping locks on shutdown. Introduced in v1.38.0.

synapse/storage/databases/main/lock.py

@@ -78,7 +78,11 @@ async def _on_shutdown(self) -> None:
         """Called when the server is shutting down"""
         logger.info("Dropping held locks due to shutdown")
 
-        for (lock_name, lock_key), token in self._live_tokens.items():
+        # We need to take a copy of the tokens dict as dropping the locks will
+        # cause the dictionary to change.
+        tokens = dict(self._live_tokens)
+
+        for (lock_name, lock_key), token in tokens.items():
             await self._drop_lock(lock_name, lock_key, token)
 
         logger.info("Dropped locks due to shutdown")