Correct type hints for computing auth events.

[clokep]

Found this while updating the implementation for MSC3083. Seemed easiest to put up a separate PR for it.

In order to not have an "unused" attribute, I need to change from using blah = attr.ib(type=Foo to blah: "Foo". I took it as an opportunity to use auto_attribs.

[erikjohnston]

In order to not have an "unused" attribute, I need to change from using blah = attr.ib(type=Foo to blah: "Foo". I took it as an opportunity to use auto_attribs.

I'm confused by this, why would using auto_attribs make a difference?

[clokep]

In order to not have an "unused" attribute, I need to change from using blah = attr.ib(type=Foo to blah: "Foo". I took it as an opportunity to use auto_attribs.

I'm confused by this, why would using auto_attribs make a difference?

Changing from declaring the type using type=blah to the native type hint syntax (foo: blah) is what fixed it, but I figured I should just switch to auto_attrib while I was doing it (to make the class consistent).

Otherwise you'd end up with:

class Klass:
    foo: int = attr.ib()
    bar = attr.ib(type=str)

[clokep]

In order to not have an "unused" attribute,

Ah -- this should say "unused import" not attribute. 😄

[clokep]

I discussed this with @MadLittleMods, although the docstring says that prev_event_ids will be computed if not given this happens in the call to create_new_client_event ~20 lines below this.

[MadLittleMods]

As discussed at https://matrix.to/#/!XaqDhxuTIlvldquJaV:matrix.org/$J_SAM4WacKXqTfcSwGfBIcos5vEJO1i6x9L38oyKPY0?via=matrix.org&via=vector.modular.im&via=envs.net