This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Split purge API into events vs state and add PurgeEventsStorage #6295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/split_purge_history
branch
from
0251a95 to
ecfba89
Compare
richvdh
suggested changes
Oct 30, 2019
richvdh
previously requested changes
Oct 31, 2019
This does mean that we won't clean up orphaned state groups (i.e. state groups that were persisted but the associated event wasn't).
richvdh
reviewed
Nov 6, 2019
| # Now we fetch all the state groups that should be deleted. | ||
| txn.execute( | ||
| """ | ||
| SELECT DISTINCT state_group FROM events |
There was a problem hiding this comment.
erm, haven't we just deleted all the relevant rows from events?
There was a problem hiding this comment.
Gah. And the tests were broken.
And fix the tests to actually test that things got deleted.
richvdh
approved these changes
Nov 6, 2019
|
Oh, |
|
it's in typing_extensions |
|
Hmm, I don't see it in |
|
gah. seems you're right. Maybe we could define our own on 3.5. This is starting to get out of scope though. |
|
I've just moved it into the docstring for now until we figure out what we're doing :) |
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit 'f713c01e2': Move type annotation into docstring Fix deleting state groups during room purge. Use correct type annotation Change to not require a state_groups.room_id index. Fix up comment Update log line to lie a little less Add state_groups.room_id index Docstrings Fix purge room API Newsfile Split purge API into events vs state
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit big as we needed to split out the purge functions to work on events and state in separate transactions.
(Split out from #6245.)