Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

/join fails with 500 if remote server times out #4755

Open
richvdh opened this issue Feb 27, 2019 · 4 comments
Open

/join fails with 500 if remote server times out #4755

richvdh opened this issue Feb 27, 2019 · 4 comments
Labels
A-Federated-Join joins over federation generally suck T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. z-p2 (Deprecated Label)

Comments

@richvdh
Copy link
Member

richvdh commented Feb 27, 2019

We time out the /make_join request after 20 seconds, but then return a non-specific Internal Server Error.

I'm not sure what the right behaviour would be - maybe a 5xx with a better error code?
@erikjohnston
Copy link
Member

I would have thought a 504?

@richvdh
Copy link
Member Author

richvdh commented Feb 27, 2019

plausible

@richvdh
Copy link
Member Author

richvdh commented Feb 27, 2019

(vaguely related: #3013)

@neilisfragile neilisfragile added z-p2 (Deprecated Label) enhancement labels Mar 5, 2019
@richvdh
Copy link
Member Author

richvdh commented Mar 19, 2020

rleated: #7108

@richvdh richvdh added the A-Federated-Join joins over federation generally suck label May 26, 2021
@erikjohnston erikjohnston added T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. and removed z-enhancement labels Jul 26, 2021
@robintown robintown mentioned this issue Sep 4, 2021
Closed
@matrixbot matrixbot mentioned this issue Dec 21, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Federated-Join joins over federation generally suck T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. z-p2 (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@neilisfragile @richvdh @erikjohnston